feat: Add restartCount as container golden metric#3072
Conversation
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- Error VALIDATING domainType: 'INFRA-CONTAINER' on Summary metrics for key ''containerRestart': wrong golden metric reference. Couldn't find a golden metric definition with key 'containerRestart', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'containerRestart': wrong golden metric reference. Couldn't find a golden metric definition with key 'containerRestart', please populate 'goldenMetric' with a valid reference to an existing golden metric.
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
2 participants
Relevant information
Added a new golden metric
restartCountto the container definition. Adding in staging first to test, then will open a new PR to add to the definition.Api Review Board (ARB)
Any pull request with changes to this repository has to be linked with an ARB ticket, which has to be approved before merging.
If you are an external contributor please contact New Relic Support.
If you don't know about the ARB process check this
ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-XXXX
Checklist
identifierwill be unique and valid.